Change in ovirt-engine[master]: utils: Preferences loader - support non-versioned keys

rgolan at redhat.com rgolan at redhat.com
Mon Oct 7 12:51:13 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: utils: Preferences loader - support non-versioned keys
......................................................................


utils: Preferences loader - support non-versioned keys

Till today the preference loader treats keys and a node with
multi-version values on it

nodeA.nodeB.value.x = 1
nodeA.nodeB.value.y = 2

so "value" is also a node and x and y are keys on the node.

this is specifig behaviour for paths in the form of a.b.c.value.x.y.z

This design is not straight forward with non-versioned keys such as:

nodeC.key = value

so we can:

 Preferences nodeC = getNodeC();
 nodeC.keys() # ["key"]
 nodeC.get("key") # "value"

Bug-Url: https://bugzilla.redhat.com/1006340
Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19794
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list