Change in ovirt-engine[ovirt-engine-3.3]: restapi, engine: Support network name in update nic

iheim at redhat.com iheim at redhat.com
Wed Oct 9 13:39:20 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: restapi,engine: Support network name in update nic
......................................................................


restapi,engine: Support network name in update nic

The network name and the port mirroring flag provided
by the restapi for updating a vnic name should be
respected. In this case the vnic profile id will be ignored.
In addition, the patch allows to set 'null' value for the
vnic profile id, which is treated as unlinking the nic from
the network:

<nic>
  <vnic_profile/>
</nic>

This patch designed for backward compatibility only of the
add/update vm nic.

Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d
Bug-Url: https://bugzilla.redhat.com/1011116
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmInterfaceParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateInterfaceParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
8 files changed, 112 insertions(+), 14 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list