Change in ovirt-engine[master]: webadmin: adding activities colume to Bricks tab

kmayilsa at redhat.com kmayilsa at redhat.com
Thu Oct 10 08:59:16 UTC 2013


Kanagaraj M has submitted this change and it was merged.

Change subject: webadmin: adding activities colume to Bricks tab
......................................................................


webadmin: adding activities colume to Bricks tab

Added a new activities column to Bricks table.
This is similar to the Actvities colume in the volumes tab.
But the cell in this column is visible only if the task
is of type REMOVE_BRICK. Added new icons to show the
different stages of remove brick operation.

All the brick removal related(stop/commit) operations are moved to
the row. The same actions will be available in the volume row as well.
Stop/Commit removal command availbility will be decided based on
the task type and status.

Refactored the code which populates the bricks in the table.

Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b
Signed-off-by: Kanagaraj M <kmayilsa at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityCompositeCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_commit_required.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_failed.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_running.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_stopped.png
14 files changed, 173 insertions(+), 60 deletions(-)

Approvals:
  Kanagaraj M: Verified
  Gilad Chaplik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list