Change in ovirt-engine[master]: backend: remove vm check from LiveMigrateDiskCommand

derez at redhat.com derez at redhat.com
Thu Oct 10 10:25:29 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: backend: remove vm check from LiveMigrateDiskCommand
......................................................................


backend: remove vm check from LiveMigrateDiskCommand

This patch shifts the VM status check from the LiveMigrateDiskCommand
to VmReplicateDiskStartTaskHandler.

This will:
* prevent CreateImagePlaceholderTaskHandler from failing if the VM
  crashes during its execution
* shift the failure to the appropriate handler (VmReplicateDiskStart)
* allow the CreateImagePlaceholderTaskHandler compensation to take
  place and remove the destination image when necessary

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957703
Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list