Change in ovirt-engine[master]: packaging: setup: add constants list to the engine

[sbonazzo at redhat.com]

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: add constants list to the engine
......................................................................


packaging: setup: add constants list to the engine

The current implementation saves to answerfile and
postinstall file only values appearing in constants.py
and matching certain criteria, ignoring any additional
constants files existing.

The new implementation brings a new structure that holds
all constants objects, and updates the answerfile/postinstallfile
implementations to work on all elements of this structure.

To use the new method, a 3rd party plugin bringing its own
constants file should add its object to environment variable
osetupcons.CoreEnv.SETUP_ATTRS_MODULES dict.

For example, for additional constants_add.py, we do:

import constants_add as constadd
self.environment[
    osetupcons.CoreEnv.SETUP_ATTRS_MODULES
].append(constadd)

Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0
Bug-Url: https://bugzilla.redhat.com/1013790
Signed-off-by: Alex Lourie <alourie at redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py
M packaging/setup/plugins/ovirt-engine-common/core/misc.py
M packaging/setup/plugins/ovirt-engine-common/core/postinstall.py
4 files changed, 18 insertions(+), 2 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>