Change in ovirt-engine[ovirt-engine-3.3]: core: in PM only selecting apc or ipmilan...

iheim at redhat.com iheim at redhat.com
Thu Oct 24 18:17:12 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core:  in PM only selecting apc or ipmilan...
......................................................................


core:  in PM only selecting apc or ipmilan...

in PM only selecting apc or ipmilan changes the options, choosing other
types is static

The reason for that was that fence options mapping were called with
'general' version and since this key is versioned, the static value for
this key in ConfigValues.java was returned. This value misses some of
the recent agents added in 3.2 and 3.3 and cause this BZ.

This patch fix this issue by getting 6the fence options mapping from the
database for the given cluster version.

Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014513
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
6 files changed, 43 insertions(+), 14 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20332
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list