Change in ovirt-engine[master]: core: improve logging on memory volumes removal failure

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Sep 30 13:23:40 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: improve logging on memory volumes removal failure
......................................................................


core: improve logging on memory volumes removal failure

Change the logging that is printed when failing to remove memory volumes
to provide more information.

This patch also contains some refactoring which should make the
'endVmCommand' method in create-all-snapshots command more simple and
readable.

Change-Id: I67897b5cd07033aff624242cdaa67d517eb14bf9
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
3 files changed, 29 insertions(+), 36 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19639
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67897b5cd07033aff624242cdaa67d517eb14bf9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list