Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: SSHDialog: close streams after sink is stopped

[oourfali at redhat.com]

Oved Ourfali has submitted this change and it was merged.

Change subject: host-deploy: SSHDialog: close streams after sink is stopped
......................................................................


host-deploy: SSHDialog: close streams after sink is stopped

this solves Pipe Closed exception happens because of try-with-resources
that was introduced at main thread, this closed the input stream before
the reader thread could terminate properly.

this also reverts 4d544a99, as it happens from same root cause, and I
read the java sources incorrectly, the buffered input stream uses
byte-by-byte read and not buffered.

add unit test to reproduce this issue.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1084911
Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
3 files changed, 167 insertions(+), 75 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I180a9883eefac57c9b528ff7b6df0eda11149255
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server