Change in ovirt-engine[master]: userportal: Edit VM on UP fails on NPE

tjelinek at redhat.com tjelinek at redhat.com
Thu Apr 10 11:58:43 UTC 2014


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal: Edit VM on UP fails on NPE
......................................................................


userportal: Edit VM on UP fails on NPE

The regression has been introduced by the SerialNumber feature:
72fcf57dc92d4e5469b1911cb5b3b42e433bd784

which adds the possibility to edit the serial number also to the UP but the
query which is supposed to return, if the serial number is supported for the
specific version is not a user query leading to a NPE in AbstractVmPopupWidget
where the isSerialNumberPolicySupported was being converted to boolean. And
since it was null, this conversion failed on NPE.

Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Verified
  Martin Betak: Looks good to me, but someone else must approve
  Gilad Chaplik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdd13ded70e3b4abb17c114ebbe86b11a3ef31ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list