Change in ovirt-engine[ovirt-engine-3.4]: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN

oourfali at redhat.com oourfali at redhat.com
Wed Apr 23 13:04:17 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
......................................................................


webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN

EnterIgnoringFocusHandler -> onPreviewNativeEvent:
execute 'enterPressed' on ONKEYDOWN event instead of
ONKEYPRESS to overcome an issue in newer Chrome/FF
browsers, in which the textarea doesn't catch the
ONKEYPRESS event. Consequently, pressing enter key
in a textarea won't break to a new line
(e.g. 'Custom Script' textarea).

Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Bug-Url: https://bugzilla.redhat.com/1064567
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Daniel Erez: Verified



-- 
To view, visit http://gerrit.ovirt.org/26978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list