Change in ovirt-engine[master]: core: Replaced the check of whether a storage pool contains ...

tnisan at redhat.com tnisan at redhat.com
Mon Apr 28 10:40:47 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Replaced the check of whether a storage pool contains mixed type
......................................................................


core: Replaced the check of whether a storage pool contains mixed type

Replaced the check of whether a storage pool contains storage domains of
mixed types to use a designated query that fetches distinct storage types
instead of fetching all the storage domains and filtering by that, in that
way we are fetching less data and eliminating the use for logic in engine
to determine if the domain is mixed thus resulting in better performance

Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list