Change in ovirt-engine[master]: core: Removing Memory Volumes Before VM and Disks

tnisan at redhat.com tnisan at redhat.com
Tue Aug 5 13:14:12 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Removing Memory Volumes Before VM and Disks
......................................................................


core: Removing Memory Volumes Before VM and Disks

removeMemoryVolumes queries the VM and its disks and thus should come
before we remove them.
Note that removeMemoryVolumes can't be inside the transaction because
it's not a pure DB operation, but also contains a VDSM (SPM) call.

Change-Id: I24851385ab1c27a1da7fe8be04cfd9d8fb744b3f
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit http://gerrit.ovirt.org/31078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24851385ab1c27a1da7fe8be04cfd9d8fb744b3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list