Change in ovirt-engine[master]: core: fix edit of sound card for running vm
ofrenkel at redhat.com
ofrenkel at redhat.com
Thu Aug 7 13:41:57 UTC 2014
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix edit of sound card for running vm
......................................................................
core: fix edit of sound card for running vm
Currently, when updating the sound card setting for running vm,
the query that checks if sound card exists is wrong, because sound card
can have multiple types of devices (ac97,ich6)
Added a code that use the "UNKNOWN" device type,
to mark the mechanism to use only the general device type (sound)
without the specific type.
Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
3 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/31035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list