Change in ovirt-engine[ovirt-engine-3.5]: ui: redundant call to vminit when initializing vms template

tnisan at redhat.com tnisan at redhat.com
Mon Aug 18 13:29:55 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: ui: redundant call to vminit when initializing vms template
......................................................................


ui: redundant call to vminit when initializing vms template

When setting vminit to desktop vm (one that have a template), we call
again vminit.init() method - after it has been initialize with the right
values.

Removing that not influence current code work-flow (ie vm, template and
pool)

Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91
Bug-Url: https://bugzilla.redhat.com/1126195
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Shahar Havivi: Verified



-- 
To view, visit http://gerrit.ovirt.org/31600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list