Change in ovirt-engine[master]: core: Add memory allocation check to hibernate VM

amureini at redhat.com amureini at redhat.com
Wed Aug 20 06:41:16 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Add memory allocation check to hibernate VM
......................................................................


core: Add memory allocation check to hibernate VM

When hibernating a VM, two volumes are created, one to save memory,
and one for the metadata. When searching for a Storage Domain with
enough space for these volumes, wrong space allocations checks are done.
Added the correct storage allocation checks, replacing existing checks
in HibernateVmCommand.
Added test class to the command - HibernateVmCommandTest, as well as a
test to VmHandlerTest.

Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a
Bug-Url: https://bugzilla.redhat.com/1124143
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
4 files changed, 136 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list