Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: fix popup dialog header text spacing
tnisan at redhat.com
tnisan at redhat.com
Mon Aug 25 14:27:36 UTC 2014
Tal Nisan has submitted this change and it was merged.
Change subject: userportal, webadmin: fix popup dialog header text spacing
......................................................................
userportal, webadmin: fix popup dialog header text spacing
Changed popup dialog header text to be spaced with CSS only.
Popup dialog header text was shifting left over the icon. This
was a regression. Hopefully permanently fixed by restructuring
the layout of the dialog header bar. Now when an icon is present,
CSS takes care of moving the header text over.
Also cleaned up some CSS class names for the dialog header.
Bug-Url: https://bugzilla.redhat.com/1119027
Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml
M packaging/branding/ovirt.brand/common.css
R packaging/branding/ovirt.brand/images/dialog/dialog_header_TL.png
A packaging/branding/ovirt.brand/images/dialog/dialog_header_TR.png
R packaging/branding/ovirt.brand/images/dialog/dialog_header_background_repetitive.png
D packaging/branding/ovirt.brand/images/dialog/dialog_header_image.png
M packaging/branding/ovirt.brand/images/dialog/error.png
M packaging/branding/ovirt.brand/images/dialog/guide.png
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
M packaging/branding/ovirt.brand/web_admin.css
12 files changed, 94 insertions(+), 85 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/31844
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list