Change in ovirt-engine[master]: core: clone VM from snapshot - validate VirtIO-SCSI

derez at redhat.com derez at redhat.com
Sun Aug 31 07:18:50 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: core: clone VM from snapshot - validate VirtIO-SCSI
......................................................................


core: clone VM from snapshot - validate VirtIO-SCSI

Validate whether VirtIO-SCSI can be disabled when cloning
a VM from snapshot (similar to the validation on UpdateVmCommand):
* Added a validation method to VmValidator.
* Added appropriate tests.

Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419
Bug-Url: https://bugzilla.redhat.com/1133475
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java
6 files changed, 137 insertions(+), 9 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31945
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31d4ebe3a964fb54cb1a905460b9da785a746419
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list