Change in ovirt-engine[ovirt-engine-3.5]: core: lenient validation of mac pool ranges in engine-config

tnisan at redhat.com tnisan at redhat.com
Mon Dec 1 13:52:47 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: lenient validation of mac pool ranges in engine-config
......................................................................


core: lenient validation of mac pool ranges in engine-config

• fail when there's no usable mac in supplied ranges

Change-Id: Id7e47c1ab1c2ffd340e1ff2596ee567557324a28
Bug-Url: https://bugzilla.redhat.com/1165025
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java
3 files changed, 94 insertions(+), 62 deletions(-)

Approvals:
  Lior Vernia: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35390
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7e47c1ab1c2ffd340e1ff2596ee567557324a28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list