Change in ovirt-engine[master]: core: Monitoring - refactor Host newtork error handling

[rgolan at redhat.com]

Roy Golan has submitted this change and it was merged.

Change subject: core: Monitoring - refactor Host newtork error handling
......................................................................


core: Monitoring - refactor Host newtork error handling

Host VDS network error should trigger a state change
and a treatment for auto-fencing as outlined in [1]

[1] http://www.ovirt.org/Automatic_Fencing

This handling is done at a single place [2] and is only called
from a single place, the VdsEventListener [3].

[2] VdsManager.handleNetworkException

[3] void onError(@Observes VdsNetworkException networkException)

*All* vds broker commands in action that throw VDS network exception is also
firing and event with the Exception as payload.

The event it caught by VdsEventListener and it invokes the handling on
using the assigned VdsManager in a separate thread.

Mo more VDSNetwork Exception throwing and re-throwing for flow control.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068
Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmStatisticsFetcherTest.java
9 files changed, 157 insertions(+), 114 deletions(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35521
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59d26baa4d372905c8249edb0aabe28ea4c4a74a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server