Change in ovirt-engine[master]: rest: Validation of the protocol values
juan.hernandez at redhat.com
juan.hernandez at redhat.com
Fri Dec 5 11:39:26 UTC 2014
Juan Hernandez has submitted this change and it was merged.
Change subject: rest: Validation of the protocol values
......................................................................
rest: Validation of the protocol values
We did not check protocol values provided so update of the host with
wrong protocol string failed on backend whereas it should fail during
initial validation.
Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1170125
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostProtocol.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/HostValidator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
6 files changed, 81 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I666b5469bcaf2bd00f793ad4320c3f37505d49b0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list