Change in ovirt-engine[ovirt-engine-3.5]: core: remove unneeded setSucceeded

[piotr.kliczewski at gmail.com]

Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: remove unneeded setSucceeded
......................................................................


core: remove unneeded setSucceeded

The following code in the started thread is executed after the tasks
were cleared, therefore there's no need to execute setSucceeded,
furthermore, as the class isn't thread safe it's risky to have that call
in terms of future changes.

Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138124
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit http://gerrit.ovirt.org/35822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server