Change in ovirt-engine[ovirt-engine-3.5]: core: DeactivateStorageDomainWithOvfUpdate - locks

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Dec 8 12:36:28 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: DeactivateStorageDomainWithOvfUpdate - locks
......................................................................


core: DeactivateStorageDomainWithOvfUpdate - locks

The lock taken by the command should be released at the end of the
endAction() method, therfore we should avoid passing it to the child
command (so it won't be released by it). Also, avoid releasing the in
memory lock while there are still tasks.

Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138124
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit http://gerrit.ovirt.org/35949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list