Change in ovirt-engine[master]: userportal, webadmin: Replace UIConstants.empty()

awels at redhat.com awels at redhat.com
Mon Dec 15 16:49:21 UTC 2014


Alexander Wels has submitted this change and it was merged.

Change subject: userportal,webadmin: Replace UIConstants.empty()
......................................................................


userportal,webadmin: Replace UIConstants.empty()

- Replaced UIConstants.empty() with "", instead of having
  a localized version of 'empty' which makes no sense and
  can in fact cause issues if the translation is not in fact
  empty.

Change-Id: I17fac230cd19dd3513df06de355171430a823257
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
4 files changed, 13 insertions(+), 17 deletions(-)

Approvals:
  Alexander Wels: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17fac230cd19dd3513df06de355171430a823257
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list