Change in ovirt-engine[master]: engine: Adjust console ticket commands

ahadas at redhat.com ahadas at redhat.com
Fri Dec 19 06:47:10 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: engine: Adjust console ticket commands
......................................................................


engine: Adjust console ticket commands

This patch makes it possible to set console ticket for multiple graphics
devices (new approach uses updateDevice command). For older VDSMs,
setTicket command is used.

TODO FOR WHOLE TOPIC:
 - restapi
 - consider renaming DisplayType to VideoType (it makes sense, the only
   drawback is ~300 LOC patch).

Change-Id: Ib62c9e29349a58156cddba1ca039cf9b7f14e610
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1033547
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetVmTicketParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
9 files changed, 113 insertions(+), 60 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Juan Hernandez: Looks good to me, but someone else must approve
  Frank Kobzik: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28574
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib62c9e29349a58156cddba1ca039cf9b7f14e610
Gerrit-PatchSet: 70
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list