Change in ovirt-engine[master]: core: Enhance RO need to update check

tnisan at redhat.com tnisan at redhat.com
Thu Dec 25 09:49:58 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Enhance RO need to update check
......................................................................


core: Enhance RO need to update check

RO property's null is interpreted as false in VmDevice and remains null
in Disk. This may result in a wrong decision whether to an update is in
need or not. This patch addresses this issue.

Change-Id: I9bbfc60c3e9bda0133eec9b1db116f8e7bad9d1d
Related-To: https://bugzilla.redhat.com/1057721
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit http://gerrit.ovirt.org/35456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9bbfc60c3e9bda0133eec9b1db116f8e7bad9d1d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list