Change in ovirt-engine[master]: core: Removed useless code from test

tnisan at redhat.com tnisan at redhat.com
Thu Dec 25 09:52:58 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Removed useless code from test
......................................................................


core: Removed useless code from test

In UpdateVmDiskCommandTest, there were recurrent mockings to
vmDeviceDao.get, which were never called in the command, therefore the
mock is useless. Now removed, along with vmDevices that are no longer
used.

Change-Id: If1580f66cc5a41583abbc936308946ea3b70939f
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
1 file changed, 15 insertions(+), 54 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit http://gerrit.ovirt.org/35458
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1580f66cc5a41583abbc936308946ea3b70939f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list