Change in ovirt-engine[master]: engine: Fix NPEx vulnerabities related to osinfo change

tjelinek at redhat.com tjelinek at redhat.com
Mon Feb 3 10:33:30 UTC 2014


Tomas Jelinek has submitted this change and it was merged.

Change subject: engine: Fix NPEx vulnerabities related to osinfo change
......................................................................


engine: Fix NPEx vulnerabities related to osinfo change

This patch fixes couple of NPEx vulnerabities related to ConsolesBase
and OS info in AsyncDataProvider.

The vulnerabities happened when changes in osinfo caused invalidity of
VMs already stored in the database.

The problem was fixed by introducing null checks in appropriate places
and a map with the possibility of returning default value if requested
key is not found.

Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1046809
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/MapWithDefaults.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
5 files changed, 74 insertions(+), 31 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Frank Kobzik: Verified



-- 
To view, visit http://gerrit.ovirt.org/23809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list