Change in ovirt-engine[ovirt-engine-3.4]: core: Add tests to StorageHandlingCommandBaseTest

iheim at redhat.com iheim at redhat.com
Mon Feb 3 10:51:51 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: core: Add tests to StorageHandlingCommandBaseTest
......................................................................


core: Add tests to StorageHandlingCommandBaseTest

Since the removal of DC type it's important to have test to test the logic
of whether attachment of domains to a pool is allowed, this patch adds tests
for the StorageHandlingCommandBase which holds most of the logic that
determines attachment is allowed

Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Relates-To: https://bugzilla.redhat.com/1038053
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
2 files changed, 212 insertions(+), 18 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23960
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list