Change in ovirt-engine[master]: core: Use FixturesTool in VmDAOTest

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Feb 5 16:40:38 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: Use FixturesTool in VmDAOTest
......................................................................


core: Use FixturesTool in VmDAOTest

Removed local constants and hardcoded values and used FixturesTools
constants instead where those existed. Where they didn't, they were
added.

The fixtures.xml file was also slightly fixed to avoid naming confusion
with non-unique names.

Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
3 files changed, 32 insertions(+), 26 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Verified
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3afb7afa9f508ea61ea3bc6502c80d0812d18fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list