Change in ovirt-engine[master]: core: Fix coverity issues

yzaslavs at redhat.com yzaslavs at redhat.com
Mon Feb 10 05:09:49 UTC 2014


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Fix coverity issues
......................................................................


core: Fix coverity issues

These issues were introduced due authentication refactoring

Change-Id: I57ff7df3075d4ca36a50016c6786ca8a69cee3e0
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalDirectory.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopDirectory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalDirectory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryGroupByIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByIdQuery.java
M backend/manager/modules/common/exclude-filters.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationFilter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Configuration.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Directory.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Manager.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/authentication/ConfigurationTest.java
13 files changed, 80 insertions(+), 53 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, but someone else must approve
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23787
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57ff7df3075d4ca36a50016c6786ca8a69cee3e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list