Change in ovirt-engine[ovirt-engine-3.4]: core: Make VM disks editable

iheim at redhat.com iheim at redhat.com
Tue Feb 11 15:28:07 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: core: Make VM disks editable
......................................................................


core: Make VM disks editable

When a VM is updated the data from the database is compared to the
updated VM object provided by the caller. But the VM object loaded from
the database doesn't contain the list of disks, so if the caller
provides an VM object that contains the list of disks the UpdateVM
command will wrongly assume that the caller is trying to modify this
list. To avoid this issue this patch marks the list of disks as
editable, so that the UpdateVM command will ignore it.

Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Bug-Url: https://bugzilla.redhat.com/1059713
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list