Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: database: support ':' within password

[iheim at redhat.com]

Itamar Heim has submitted this change and it was merged.

Change subject: packaging: setup: database: support ':' within password
......................................................................


packaging: setup: database: support ':' within password

at least in rhel postgresql 8.4 the pgpassfile is not read according to
documentation, the password is read as plain, postgresql 9 seems to
respect the documentation.

this behavior is handled by client side postgresql libraries, the
simplest way to detect what library we use is to query psql utility
version.

[1] http://www.postgresql.org/docs/8.4/static/libpq-pgpass.html

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064428
Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/bin/engine-backup.sh
M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
3 files changed, 84 insertions(+), 6 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Sandro Bonazzola: Looks good to me, approved
  James W. Mills: Verified; Looks good to me, but someone else must approve
  Yedidyah Bar David: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24460
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I866680c853c1e1978d55828ff4efd710a1003f9a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: James W. Mills <jamills at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server