Change in ovirt-engine[ovirt-engine-3.4]: webadmin, userportal: Use X-UA-Compatible with IE=10

iheim at redhat.com iheim at redhat.com
Fri Feb 14 15:38:17 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin,userportal: Use X-UA-Compatible with IE=10
......................................................................


webadmin,userportal: Use X-UA-Compatible with IE=10

This patch is meant to address problems when loading
GWT applications in Internet Explorer 11.

IE11 user agent string is missing the "MSIE" part but
instead includes the "like Gecko" part. For example:

  Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko

This causes GWT selector script (*.nocache.js) to pick
and load Firefox (Gecko) permutation of GWT application.

Since IE11 has issues with Gecko permutation [1], the
workaround is to tell IE11 to render page as IE10:

  <meta http-equiv="X-UA-Compatible" content="IE=10">

[1] http://code.google.com/p/google-web-toolkit/issues/detail?id=8228

This shouldn't affect behavior of GWT applications
when loaded in earlier Internet Explorer versions:
- IE8: selector script uses 'ie8' permutation
- IE9: selector script uses 'ie9' permutation
- IE10: selector script uses highest available
  permutation ('ie9')

Note: there might be issues with IE10 + 'ie9' GWT
permutation combination. These issues should be
addressed as part of GWT upgrade which should add
proper support (permutation) for IE10.

Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Bug-Url: https://bugzilla.redhat.com/1062716
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Looks good to me, but someone else must approve
  Vojtech Szocs: Verified



-- 
To view, visit http://gerrit.ovirt.org/24211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad89cbd057fc63944a09478ed92e29c13a49e04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list