Change in ovirt-engine[ovirt-engine-3.4]: core: Fix storage validations for extending a disk

[iheim at redhat.com]

Itamar Heim has submitted this change and it was merged.

Change subject: core: Fix storage validations for extending a disk
......................................................................


core: Fix storage validations for extending a disk

Use StorageDomainValidator.hasSpaceForNewDisk(DiskImage) method, which
is sensitive to the type and format of the disk. Although a new disk is
NOT added, the extension is essentially empty, so sans some overhead, it
can be considered as a new disk.

This patch includes fixing the command and adding some basic unit tests
to the flow.

Change-Id: I76d38c41321495b9e12087dc4698f67830d7a1d4
Bug-Url: https://bugzilla.redhat.com/1053740
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 51 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24621
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76d38c41321495b9e12087dc4698f67830d7a1d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server