Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: more changes in NotificationProperties
iheim at redhat.com
iheim at redhat.com
Thu Feb 20 15:22:48 UTC 2014
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: more changes in NotificationProperties
......................................................................
tools: notifier: more changes in NotificationProperties
split validate into sub calls (validateBasic, validateEmail ...) to sections.
as more sections are expected in following commits (validateFilter, validateSnmp ).
Order methods (constructor befor any other method).
Apply code style & add requireAll and requireOne methods.
Change-Id: I2ebbf76a23c79d354cb9026dc3ad0f4310a804be
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
1 file changed, 141 insertions(+), 89 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ebbf76a23c79d354cb9026dc3ad0f4310a804be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list