Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Document the Agent FSM using docstrings and autogenerate the...

msivak at redhat.com msivak at redhat.com
Fri Feb 21 09:48:00 UTC 2014


Martin Sivák has submitted this change and it was merged.

Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources
......................................................................


Document the Agent FSM using docstrings and autogenerate the graphviz sources

This adds two special lines to state class docstrings:

:transition[ destination]: description
- describes transition from current class to destination
- it is treated as staying in the current state when
  destination is not provided

:transitions_from StateClass:
- used to support inheritance, copies all transitions
  from StateClass to the current class

This patch also adds a script that reads the state_machine.py and
states.py modules and generates the fill graphviz source for the
state machine.

make fsm then generates the new source and png file with the state
machine.

Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Signed-off-by: Martin Sivak <msivak at redhat.com>
(cherry picked from commit 21a18395a2b9d8724a3712910e20efaed78ae3ac)
---
M Makefile.am
A build/build-aux/gen_gv.py
M doc/agent-fsm.gv
M ovirt_hosted_engine_ha/agent/state_machine.py
M ovirt_hosted_engine_ha/agent/states.py
5 files changed, 258 insertions(+), 31 deletions(-)

Approvals:
  Martin Sivák: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24857
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>



More information about the Engine-commits mailing list