Change in ovirt-engine[master]: core: run HA VMs that went down right before engine stopped

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Jan 1 17:45:02 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: run HA VMs that went down right before engine stopped
......................................................................


core: run HA VMs that went down right before engine stopped

This patch solves a known problem that was exists before: when HA VMs
went down, the engine (VdsUpdateRunTimeInfo) detected it (and updated
the DB) but didn't manage to run the VM, we won't try to run the VM when
the engine start.

This problem is solved by fetching from the DB all the HA VMs which are
down with exit status ERROR when initializing the AutoStartVmsRunner
job, and those VMs are set as the first VMs the job will try to run on
its first iteration.

Change-Id: I2d5876f196819b2a69be0b71287c5325a8ff9dc9
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/vms_sp.sql
6 files changed, 58 insertions(+), 6 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d5876f196819b2a69be0b71287c5325a8ff9dc9
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list