Change in ovirt-engine[master]: core: validate IQN on update iSCSI connection

derez at redhat.com derez at redhat.com
Sun Jan 5 08:41:21 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: core: validate IQN on update iSCSI connection
......................................................................


core: validate IQN on update iSCSI connection

* Add a canDo validation to UpdateStorageServerConnectionCommand
  for empty IQN (similar to AddStorageServerConnectionCommand).
* Updated unit tests accordingly.

Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c
Bug-Url: https://bugzilla.redhat.com/1005284
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
2 files changed, 20 insertions(+), 5 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22880
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list