Change in ovirt-engine[master]: core: findbugs: inconsistent synchronization

oourfali at redhat.com oourfali at redhat.com
Tue Jan 7 17:37:00 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: findbugs: inconsistent synchronization
......................................................................


core: findbugs: inconsistent synchronization

AsyncTasksManager is currently the only class with suffers from
inconsistent synchronization. This patch does not solve those issues (in
an attempt to "not rock the boat", but preserve the current situation).
It does, however, move the exclusion of this check out of
exclude-filters-general.xml and fine-grains it to exclude only
AsyncTasksManager in order to avoid these potentially dangerous bugs in
future classes.

Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
M exclude-filters-general.xml
2 files changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23035
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list