Change in ovirt-engine[master]: packaging: services: remove pid when service start fails

sbonazzo at redhat.com sbonazzo at redhat.com
Wed Jan 8 14:44:19 UTC 2014


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: services: remove pid when service start fails
......................................................................


packaging: services: remove pid when service start fails

the service is running under non privileged user, so it cannot remove
the pid file only clear it.

if service is dead at validation stage its status is printed as:

  dead but pid file exists

to remedy that, if service fails to start we remove the pid if service
start fails and pid file is zero length.

Related-To: https://bugzilla.redhat.com/989382
Change-Id: I8c5ff88aef181dbf4955bd976c176642290e13d0
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in
M packaging/services/ovirt-engine/ovirt-engine.sysv.in
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23066
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5ff88aef181dbf4955bd976c176642290e13d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list