Change in ovirt-engine[master]: core: fix virtio-scsi validation on update VM

derez at redhat.com derez at redhat.com
Wed Jan 15 17:26:17 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: core: fix virtio-scsi validation on update VM
......................................................................


core: fix virtio-scsi validation on update VM

Fix VirtIO-SCSI validation when updating a running VM:
* Added a new signature for vmDeviceChanged method which
  gets also a specific VmDeviceType.
** Needed for using getVmDeviceByVmIdTypeAndDevice
   method from VmDeviceDao. I.e. instead of fetching
   all devices of VmDeviceGeneralType.CONTROLLER,
   filter also by VmDeviceType.VIRTIOSCSI specifically.
* Added new test-cases for updating a running VM.

Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204
Bug-Url: https://bugzilla.redhat.com/1049272
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
2 files changed, 64 insertions(+), 2 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23052
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list