Change in ovirt-engine[ovirt-engine-3.4]: UI: hot set number of CPU when updating a VM

iheim at redhat.com iheim at redhat.com
Tue Jan 28 16:54:53 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: UI: hot set number of CPU when updating a VM
......................................................................


UI: hot set number of CPU when updating a VM

* allow updating the number of sockets of a runing VM
* disable number of cores per sockets change
* disable total number of cpus change
* added a icon which explains about the action taken when changing the
* values.

Any change to the socket field will recalculate the total CPUs.
This means we add/remove whole sockets from a VM.

Changing the topology, i.e. the number of CPUs per socket is not allowed
as it can not be reflected in a live OS.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036777
Change-Id: Ieac0e757c54b002eeab8f9099e6e8d151eb43340
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 123 insertions(+), 13 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23478
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieac0e757c54b002eeab8f9099e6e8d151eb43340
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list