Change in ovirt-engine[ovirt-engine-3.4]: Fixing broken VMs search

[iheim at redhat.com]

Itamar Heim has submitted this change and it was merged.

Change subject: Fixing broken VMs search
......................................................................


Fixing broken VMs search

The work done to support the cloud init feature removed the vm_domain
column however this column was not removed from the search.
Therefore , searching on VMs tab with for example "VMs:vm1" throws the
following exception

 Position: 208: org.springframework.jdbc.BadSqlGrammarException:
StatementCallback; bad SQL grammar [SELECT * FROM (SELECT * FROM vms
WHERE ( vm_guid IN (SELECT vms_with_tags.vm_guid FROM  vms_with_tags
WHERE  (  vms_with_tags.vm_pool_name ILIKE '%vm1%' OR
vms_with_tags.run_on_vds_name ILIKE '%vm1%' OR  vms_with_tags.vm_domain
ILIKE '%vm1%' OR  vms_with_tags.tag_name ILIKE '%vm1%' OR
vms_with_tags.guest_cur_user_name ILIKE '%vm1%' OR
vms_with_tags.vm_name ILIKE '%vm1%' OR  vms_with_tags.vm_description
ILIKE '%vm1%' OR  vms_with_tags.quota_name ILIKE '%vm1%' OR
vms_with_tags.vm_host ILIKE '%vm1%' OR  vms_with_tags.vm_ip ILIKE
'%vm1%' OR  vms_with_tags.storage_pool_name ILIKE '%vm1%' OR
vms_with_tags.vds_group_name ILIKE '%vm1%' OR  vms_with_tags.vm_comment
ILIKE '%vm1%' ) ))  ORDER BY vm_name ASC ) as T1 OFFSET (1 -1) LIMIT
100]; nested exception is org.postgresql.util.PSQLException: ERROR:
column vms_with_tags.vm_domain does not exist

This patch removes the vm_domain  column from the search engine code as
well.

Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Eli Mesika: Verified
  Shahar Havivi: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server