Change in ovirt-engine[master]: core: Modify constructor to be compatible with caller method

yzaslavs at redhat.com yzaslavs at redhat.com
Mon Jul 7 02:05:39 UTC 2014


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Modify constructor to be compatible with caller method
......................................................................


core: Modify constructor to be compatible with caller method

ConnectDomainToStorageCommand is being called without context
although its constructor is only supported with context parameter,
so we will always get runtime exception when the command is being
called.

The proposed fix is to add a constructor which also supports to get only
paramteres

Change-Id: Ic120c4b33b40a122895c2088b8365f26c05eb517
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic120c4b33b40a122895c2088b8365f26c05eb517
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list