Change in ovirt-engine[master]: core: VmLogonCommand - missing constructor

derez at redhat.com derez at redhat.com
Mon Jul 7 05:48:06 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: core: VmLogonCommand - missing constructor
......................................................................


core: VmLogonCommand - missing constructor

VmLogonCommand is invoked only from client (UserPortal/REST),
hence, a missing constructor causes a RuntimeException [1]
when connecting to console. Added a new ctr without
the CommandContext parameter.

Note: InternalCommandAttribute annotation should probably be
removed as the action is performed merely from the client.

[1] "could not find matching constructor for Command class class
org.ovirt.engine.core.bll.VmLogonCommand"

Change-Id: If0c750656a01e51614553427551896cfd6b54dd5
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Daniel Erez: Verified
  Omer Frenkel: Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0c750656a01e51614553427551896cfd6b54dd5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list