Change in ovirt-engine[master]: engine : NPE while using reflection for AsyncTask type

oourfali at redhat.com oourfali at redhat.com
Mon Jul 7 11:43:05 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: engine : NPE while using reflection for AsyncTask type
......................................................................


engine : NPE while using reflection for AsyncTask type

If the server is restarted before the async task place holder
can be updated with the vdsm id, the async task manager
creates a new async task row with action_type unknown. If
a command is constructed from this data for CommandAsyncTask
VdcActionType Unknown results in no command being found throwing
an exception.

When action_type is unknown, SPMAsync task is constructed instead
of command async task.

Change-Id: Ic186992e1f1d4d6a870b323cc018b6cf3e67645a
Bug-Url: https://bugzilla.redhat.com/1112557
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ravi Nori: Verified
  Arik Hadas: Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/29156
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic186992e1f1d4d6a870b323cc018b6cf3e67645a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list