Change in ovirt-engine[master]: dal: Refactor VmStatic and VmTemplate Daos

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Jul 7 12:33:00 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: dal: Refactor VmStatic and VmTemplate Daos
......................................................................


dal: Refactor VmStatic and VmTemplate Daos

Extracted common fields from parameter sources of VmStatic and
VmTemplate to new VmBaseDaoDbFacade.

This new class also inheriths DefaultGenericDaoDbFacade to eliminate
trivial implementations of get, update and delete in both
DaoDbImpls.

Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
5 files changed, 160 insertions(+), 211 deletions(-)

Approvals:
  Martin Betak: Verified
  Roy Golan: Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29544
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list