Change in ovirt-engine[master]: core: remove redundant synchronization (CoCo cleanup)

oourfali at redhat.com oourfali at redhat.com
Tue Jul 8 05:16:34 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: remove redundant synchronization (CoCo cleanup)
......................................................................


core: remove redundant synchronization (CoCo cleanup)

a method which is executed by our quartz in fixed delay can only be
executed by one thread at each given time, because before executing
it we remove it from the quartz pool and when it ends we put it back.
so no need to synchronize anything for protecting from parallel
executions of the same critical section

Change-Id: I588de14e21f19ef59781b382b2450b8723635667
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
1 file changed, 5 insertions(+), 10 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Arik Hadas: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I588de14e21f19ef59781b382b2450b8723635667
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list