Change in ovirt-engine-sdk[sdk_3.5]: codegen: Calculate singulars correctly

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jul 9 12:55:13 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: codegen: Calculate singulars correctly
......................................................................


codegen: Calculate singulars correctly

There are a few places in the code generator where the singular form of
words is calculated directly removing the last character, assuming it
will be an "s". This isn't correct, as there are exceptions. The correct
way is to call the StringUtils.toSingular() method.

Change-Id: I2869fd1c1356386f8b87d29affd41f727077b17c
Bug-Url: https://bugzilla.redhat.com/1114655
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/codegen/rsdl/rsdlcodegen.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2869fd1c1356386f8b87d29affd41f727077b17c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list