Change in ovirt-engine-sdk[sdk_3.5]: sdk: Calculate singulars correctly

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jul 9 12:55:54 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Calculate singulars correctly
......................................................................


sdk: Calculate singulars correctly

There are a few places in the code generator where the singular form of
words is calculated directly removing the last character, assuming
it will be an "s". This isn't correct, as there are exceptions. The
correct way is to call the StringUtils.toSingular() method.

A previous patch fixed that in the code generator. This patch updates
the generated code. That removes an incorrectly generated
"SchedulingPolicie" class.

Change-Id: I1c1a8665d9d49ac496ab13cea9ce08a45d906184
Related: https://bugzilla.redhat.com/1114655
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtsdk/infrastructure/brokers.py
1 file changed, 15 insertions(+), 36 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c1a8665d9d49ac496ab13cea9ce08a45d906184
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list